search

Travix-International / Hystrix.Dotnet

A combination of circuit breaker and timeout. The .net version of the open source Hystrix library built by Netflix.
https://travix-international.github.io/Hystrix.Dotnet/
MIT License
95 stars 16 forks source link

Add HystrixThreadPool to the stream #5

Open bhugot opened 7 years ago

bhugot commented 7 years ago

Hi, There is a missing part of stream for HystrixThreadPool.

Would be nice to have it

markvincze commented 7 years ago

Hi @bhugot,

You mean that HystrixThreadPoolMetrics doesn't have a real implementation, it's just returning dummy values, right?

@JorritSalverda do you remember what is the status of that? I remember we had some technical limitations preventing us from properly implementing this at the time. Or is it just that we haven't got around to do it yet?

JorritSalverda commented 7 years ago

@markvincze @bhugot The tracking of thread pool metrics in the original Hystrix library makes sense because you can create multiple thread pools in Java. However when I ported the library to .net I found out there's no such thing in asp.net. I did collect some metrics briefly to see if was of any use in the Hystrix dashboard, but it turned out to be really useless, so we might as well remove it altogether.

To get a better understanding of your thread pool metrics I would look at using Prometheus and the WMI exporter to collect those.