Closed zdelagrange closed 8 years ago
Master is currently broken for me locally as well.
Master is broken? @cyprien-g can you confirm?
You need to add test cases to check your code for corectness @zdelagrange. Add a "header" parameter in our swagger file and check that it is indeed tested
Master is working again. But there is an error in your header creation: https://travis-ci.org/Trax-air/swagger-tester/jobs/117155008
Again, if you could add a test case, that would be great
I hate to keep passing the buck on these tests, but is this endpoint broken on petstore.swagger.io?
I restarted the test and it passed. We need to get rid of the online swagger api test.
It seems good for me. @traxair what do you think ?
The test case doesn't seem to be really a test case. It's good that we have a header parameter, but there should be some other validation
Yes, but it is because we don't have real tests for now. That's why I opened #19
Ok cool, good for me then Le 25 mars 2016 10:48, "Cyprien G" notifications@github.com a écrit :
Yes, but it is because we don't have real tests for now. That's why I opened #19 https://github.com/Trax-air/swagger-tester/issues/19
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Trax-air/swagger-tester/pull/16#issuecomment-201223241
@zdelagrange Your contribution is really appreciated, and is available in the last release on pypi :smile:
thanks @cyprieng I can relate with the "no real tests" thing. thanks for being active on this repo! this is a really cool package!
Closes #14