search

Trax-air / swagger-tester

Automatically test your swagger API
MIT License
105 stars 36 forks source link

Use generated operations #27

Closed jfinkhaeuser closed 8 years ago

jfinkhaeuser commented 8 years ago

Depends on Trax-air/swagger-parser#21

Uses generated operations and operations with an operationId, otherwise there's no change.

jfinkhaeuser commented 8 years ago

@beanqueen

cyprieng commented 8 years ago

Can you fix the test, so I could merge ? Thanks

cyprieng commented 8 years ago

Ok sorry, it seems there is the same issue on master #32

jfinkhaeuser commented 8 years ago

There's an issue with connexion here; I want to send them a PR. Basically, connexion errors out when it doesn't get an operationId, instead of reporting a 500 or 404 or whatever makes most sense to them for that path.

I'll link the PR here when I've made it.

jfinkhaeuser commented 8 years ago

It turns out it's better to make two PRs. The first is zalando/connexion#274 - it just makes errors from bad operationIds more readable.

The next PR will be handling those errors at run-time, turning them into some 5xx code.

jfinkhaeuser commented 8 years ago

So I ended up making a bunch of PRs, but the one that matters would be zalando/connexion#278

Others:

jfinkhaeuser commented 8 years ago

So, it seems that connexion merged all my PRs, after some cleanup and discussion. Yay!

That should be enough to fix the tests, at least with the master of connexion

cyprieng commented 8 years ago

Good! But we need them to update connexion on pypi, so we could update our requirements.

cyprieng commented 8 years ago

@jfinkhaeuser connexion has been updated on pypi. Can you update the requirements.txt ?

jfinkhaeuser commented 8 years ago

Thanks to #36, this is now basically a useless PR. Still, look at the diff (flake8 fix, largely).