search

TrebleDroid / treble_experimentations

Scripts to automatically build/CI/Release TrebleDroid GSI
Other
212 stars 27 forks source link

fixSPL() setting ro.keymaster.xxx.release incorrectly #118

Closed Rocky7842 closed 4 months ago

Rocky7842 commented 4 months ago

Current Behavior:

Keyamster crashing, bootloop. ### Describe the bug `fixSPL()` set `ro.keymaster.xxx.release` to `13` while `9.0.0` is expected, causing keyamster to crash. ### Expected behavior Set `ro.keymaster.xxx.release` to the expected value. ### Smartphone (please complete the following information): - Device: Asus Rog Phone 1 - Build Flavor: system-td-arm64-ab-vanilla.img.xz - Version: android_13.0.0_r73 ci-20230905 ### Additional context Basically it's broken after https://github.com/TrebleDroid/device_phh_treble/commit/1903aeb0b9b75163d6c0885a7c72697a0837d78e. The re-written version https://github.com/TrebleDroid/device_phh_treble/commit/a0d7bfa444dd5ee28c214cb91b22b07e9ccb01a0 (which is the one we have in A14 too), sets `ro.keymaster.xxx.release` to `13`. Interestingly using the original code and adding https://github.com/Rocky7842/device_phh_treble/commit/10cc7ee18acf8cb1176922fd702c6fd0f418682c would have it correctly set to `9.0.0` and allow the following code to run without returning at the check. Please advise on this. I can do a PR accordingly if needed.
Rocky7842 commented 4 months ago

LOL it's me for some reason was using a vbmeta from other devices apparently. The re-written version can get the correct ro.keymaster.xxx.release from vbmeta.