search

Treblle / treblle-laravel

The official Treblle SDK for Laravel. Seamlessly integrate Treblle to manage communication with your dashboard, send errors, and secure sensitive data.
https://www.treblle.com/
MIT License
129 stars 24 forks source link

Support for non-fast CGI servers #1

Closed khalyomede closed 3 years ago

khalyomede commented 3 years ago

First of all, congratulations for this package, great job done here!

Description

I installed and configured the package, but unfortunately I could not see results on my Treblle dashboard because I noticed we are not using FastCGI on our test server.

By tweaking the code of the middleware a bit, I managed to find a solution to send a payload to my dashboard (see Suggestion).

Proposal

I think we could have an option, "use fast CGI", which is by default to true (to not break the previous behavior), and can be set to false. In this case, the terminate method could be called manually inside the handle method. What do you think?

Notes

This is the code I added to be able to see my endpoints payloads on my dashboard:

public function handle($request, Closure $next) {

  $response = $next($request);

  $this->terminate($request, $response); // <--

  return $response;
}
cindreta commented 3 years ago

🎉 Congrats and thank you! If you would be so kind to shoot me an email at vedran@treblle.com and just send me the email you used to register on Treblle so i bump your access for free 🙌🏻