[CRITICAL] Set request API Key Using Package Config Variables

Treblle / treblle-laravel

The official Treblle SDK for Laravel. Seamlessly integrate Treblle to manage communication with your dashboard, send errors, and secure sensitive data.

https://www.treblle.com/

MIT License

129 stars 24 forks source link

[CRITICAL] Set request API Key Using Package Config Variables #44

Closed stephenjude closed 1 year ago

stephenjude commented 1 year ago

This PR fixed the issue of request not hitting the dashboard because Treblle API was hardcoded inside the package. I believe this is an error of omission.

How fast can we merge this PR @JustSteveKing

khalyomede commented 1 year ago

Since this is a regression I think a test would be more than welcome in my opinion.

Good catch tho!

JustSteveKing commented 1 year ago

Hey @stephenjude just double checking this, as this was in place on the old version of the package!

Thank you for your diligence though!

stephenjude commented 1 year ago

@JustSteveKing
Here is the current implementation on the master branch: https://github.com/Treblle/treblle-laravel/blob/master/src/TreblleServiceProvider.php

stephenjude commented 1 year ago

@JustSteveKing this PR has halted the use of Treblle on my Laravel project.

JustSteveKing commented 1 year ago

Sorry for the delay @stephenjude - there will be a new release out within the next couple of hours.

I had to double check the auth constraints with the team before I made any changes.

I will need to expand on this PR slightly, and want to make sure I wrap enough tests around it.

Again, sorry for any delays

JustSteveKing commented 1 year ago

@stephenjude this is now in PR: https://github.com/Treblle/treblle-laravel/pull/45

I do not have permission to work on your branch, so had to move it to my own.

stephenjude commented 1 year ago

Thanks @JustSteveKing