search

Treblle / treblle-laravel

The official Treblle SDK for Laravel. Seamlessly integrate Treblle to manage communication with your dashboard, send errors, and secure sensitive data.
https://www.treblle.com/
MIT License
129 stars 21 forks source link

Load Time Problems #72

Closed cindreta closed 1 year ago

cindreta commented 1 year ago

Version

Description

After upgrading to version 4.0.35 on our internal API we started seeing load times that do not seem to be correct again. We had this problem before and it seems to be creeping in again. We are running on top of Vapor + Octane. This might be causing problems. If someone else is running regular Laravel (not vapor) they can check me.

Steps to reproduce

  1. Install treblle-laravel 4.0.35 on your API
  2. Make sure you are running Vapor + Octane
  3. Make a test request and see it in the Treblle dashboard

Expected behavior

The load times should not be as high as it is right now.

Notes

As I've mentioned we had this bug already on Vapor/Octane.

JustSteveKing commented 1 year ago

Thanks @cindreta so the way this works currently is that we take the current time and minus the start of request time. This works in almost all situations other than Vapor and Octane. This is extended if you are warming lambdas or have a jump box because of how Octane works.

I will investigate a fix for this that shouldn't effect other use cases

JustSteveKing commented 1 year ago

Fixed in latest release