search

Trebor-Huang / vscode-forester

VSCode support for Forester
https://marketplace.visualstudio.com/items?itemName=treborhuang.vscode-forester
19 stars 1 forks source link

Completion when there's a lot of trees is slow #5

Closed Trebor-Huang closed 9 months ago

Trebor-Huang commented 9 months ago

Can we do the stream thing and add to the list asynchronously?

Trebor-Huang commented 9 months ago

We can rescan only when the workspace has filesystem change events

Trebor-Huang commented 9 months ago

Javascript promise is so weird

Trebor-Huang commented 9 months ago

Forester somehow outputs error messages in stdout (the default of asai).

kentookura commented 9 months ago

I suspect making use of the forester errors in our plugins requires some changes to forester. I also think it's time to make the error messages available in json.

jonsterling commented 9 months ago

Let me tag @Favonia.

Trebor-Huang commented 9 months ago

asai has the option to output to stderr, and to remove the fancy dressing. So a commandline option to forester should suffice

jonsterling commented 9 months ago

It seems like these are two separate things — shouldn't warnings and errors always go to stderr no matter what? If it is currently going to stdout, that should probably be corrected regardless of the tooling issues. And we could provide an option to remove the fancy dressing separately. sound reasonable?

Trebor-Huang commented 9 months ago

This discussion is somewhat unrelated to the issue, which I closed because I implemented a rate-limited scanning triggered by filesystem changes. Now operating a large forest should be relatively fast.