TreeMama / iSeaTree-React-Prototype

Prototype for the iSeaTree (a mobile app which creates compatible data collection for the iTree project).
MIT No Attribution
14 stars 9 forks source link

V4+ (dependbot) Upgrade simple-plist to 1.3.1 #476

Open TreeMama opened 1 year ago

TreeMama commented 1 year ago

ToDO:

We need to upgrade simple-plist. Dependbot sent us the following alert - AND @jgrenadier noted we need to fix the menu error that occurs AFTER we upgrade.

test in ios and android :)

213614033-c2e69a55-ab70-488e-b1d2-32649a205c8b

jgrenadier commented 1 year ago

My guess is that changing the simple-plist version, caused a different package to change version which caused this gui error. A possible fix would be to change LoggedTabNavigator.tsx line 55 to add a bottom margin of 5. It seems that was there in a previous version but was removed. Here is the code change: return ( <Tab.Navigator activeColor={theme.colors.primary} screenOptions={{ headerShown: false, tabBarStyle: { position: 'absolute', bottom: 5, // jag elevation: 0, backgroundColor: 'white', // height: 90, }, }} tabBarOptions={{ showLabel: false, headerShown: false, }}

I'll let this sit for a day or so, to see if anyone else has some insight into whether this fix is reasonable before uploading any changes.