search

TreeMama / iSeaTree-React-Prototype

Prototype for the iSeaTree (a mobile app which creates compatible data collection for the iTree project).
MIT No Attribution
14 stars 9 forks source link

Fix 476 navigator displaying issue #522

Closed kafkakk closed 1 year ago

kafkakk commented 1 year ago

I didn’t observe any navigator display issues, as depicted in the screenshot on Android. The problem seems to be related to certain older iPhone models, such as the iPhone 8. I enlarged the size of the navigator on the bottom to address the gap between the navigator and the map(in the map screen). Tested on the iPhone 8, iPhone 11, and iPhone 14 Pro simulators and Nexus One and Pixel 6 emulators. Please try to test on your side.

bestw07 commented 1 year ago

Hi, Lawrence Zhao.

Did you build it from Mac or Windows system?

bestw07 commented 1 year ago

Hi @kafkakk .

I uploaded the screenshot of the app.

It looks like there are some gaps.

You can check the red-marked parts.

And I should install the pod module again, that's why I asked which OS did you use for the build.

Also, send a review request to @TreeMama (Ari) as well.

Screenshot at Aug 10 20-11-38
bestw07 commented 1 year ago

I pushed my changes (for ios build), @kafkakk .

kafkakk commented 1 year ago

@bestw07 I built on macOS

kafkakk commented 1 year ago

I see the issue. On my profile, the badges are few, so on my page it looks good. I will fix it.

kafkakk commented 1 year ago

Hi, @bestw07. I've acquired sufficient badges to replicate the display issue on your end. I resolved the problem and subsequently reorganized the map layout. I think the map no longer experiences partial coverage by the navigator, as you can see the complete visibility of the Apple logo in the lower left corner. And my build was conducted on macOS. Tested on the iPhone 8, iPhone 11, and iPhone 14 Pro simulators and Nexus One and Pixel 6 emulators.

@jgrenadier Jim, can you test on Android?

iShot_2023-08-11_17 10 19

bestw07 commented 1 year ago

good, thank you for your update, @kafkakk .

Let me pull and test it.

bestw07 commented 1 year ago

it looks good.

Once Ari @TreeMama confirmed, we can merge it to develop branch.

Screenshot_1691806824

simulator_screenshot_FA0C90FC-6548-43F9-A415-513C00D78DF3

jgrenadier commented 1 year ago

basic menus look ok on android. Cant test the badge issue since map not displaying. This is probably just a testing issue but probably because no map showing, I get an exception after adding a tree. Screen capture of exception: https://www.dropbox.com/scl/fi/v159079mqyb9rh1vf6c2z/Screenshot_20230811-215036.png?rlkey=qgze8jwx1w4492ldbgqv2v04p&dl=0 I'll try some workarounds tomorrow for more testing. Again: I think the exception that I saw was related to my test environment and not this code change. More later.