Replace unsafe shooting star functions with iterator

Treeki / MeteoNook

weather prediction tool for Animal Crossing: New Horizons

GNU Affero General Public License v3.0

279 stars 59 forks source link

Replace unsafe shooting star functions with iterator #83

Open panicbit opened 2 years ago

panicbit commented 2 years ago

The current shooting star functions (query_stars, get_star_second) unsafely use a global mutable static array (LAST_STAR_SECONDS). This is not a real issue for usage on the website, but it is an issue for the project that I'm currently working on.

This PR replaces those functions with a safe iterator :smiley:.