UPDATED: QUEST_JOBSTEP.tsv LINES 700 - 899 and QUEST.tsv LINES 15-21 & 87 Shall now be in-progress

[MystesofEternity]

I didn't get into the iCBT during this vacation time of mine so I figured I'd like to help through this way instead of just idling around and doing nothing.

So I've decided to primarily work upon the QUEST_JOBSTEP.tsv file and working along the lines I've specified above and I'm not going beyond that for now since I've seen a bunch of pull requests already for this file and I won't even bother check each and every one of the requests that may or may not be approved. But at least I'm thankful that one pull request kindly indicated the lines on their request so I might as well take that for convenience and put up an issue here before I send a pull request regarding those lines that I shall take charge :D

Hope I'll be of help as much as I can and so I put up this issue just as the guidelines have indicated before I fully finish my part of the work and submit a pull request regarding it.

Oh and is it alright for me to put an x at the start of each line that seems to be good enough for deployment in the game for QUEST_JOBSTEP.tsv?

EDIT: Title has been edited and I shall now start work on QUEST_JOBTEP.tsv LINES 700 - 899 with changes on QUEST.tsv LINES 15-21 & 87

[Ragunaga]

https://github.com/Treeofsavior/EnglishTranslation/pull/643

That pull request edited various lines in that range.

The lines from 700+ are mostly available tho, you can easilly check by looking at the file changes on each pull request.

[MystesofEternity]

Thanks for the speedy reply! I'll do just that then Starting from line 700 up till 1200 :+1:

[Ragunaga]

Break it up a little, there's a guildline in place, don't do more then 300 line changes because it's size is too large.. (More like 150 line edits, each counts twice.).

You rack up that many in probably 200 lines. Do 700-899 instead or something.

https://github.com/ensata/ToS-en-fork/blob/notes/GitHub_Usage.txt

EDIT; also this https://github.com/Treeofsavior/EnglishTranslation/issues/540

[MystesofEternity]

Oh ok but can I follow-up the rest of the lines through a future pull request or should I just leave it for later? xD

[Ragunaga]

I suppose you can, but I'd wait. Honestly they have a ton of pull requests right now.

[MystesofEternity]

Yeah I did notice and it's terrible @_@ Alright guess I'll just do 700-899 then xD

[ttgmichael]

Hey @MystesofEternity, Not sure if you are still working on JOBSTEP lines 700-899; if you are, I encourage you to join the Discord Server mentioned on this issue https://github.com/Treeofsavior/EnglishTranslation/issues/850; this is where most of the contributors are right now and some have started working on the lines that you have done. It'll be a great time to discuss any differences before submitting a PR of these lines.

[MystesofEternity]

Oh sorry if I haven't put much of an update. Currently I haven't been able to do anything to lines 724-815 due to lack of data so feel free to work on those as I handled improvement on 816-899.

Also, I'm already in the discord channel, what should I say? Oh and I'm also ready to submit a pull request whenever.

[ttgmichael]

Gotcha,

Still, I think there were people working on 816-899 as well (We have essentially covered all of JOBSTEP); I highly encourage you to work with them on Discord (we just chat w/o voices right now) to sort out what lines will be pulled before doing so ^^;

[MystesofEternity]

Oh alright I'll try to participate xD