search

Treer / Amidst-for-Minetest

the Amidst project converted to support Minetest (aka Amidstest)
https://www.minetest.net/
GNU General Public License v3.0
27 stars 2 forks source link

Solved #5

Closed KCoombes67 closed 6 years ago

KCoombes67 commented 6 years ago

Solved

Treer commented 6 years ago

Sorry, what was this?

It was solved before I saw it, was it anything that might affect/help other people?

KCoombes67 commented 6 years ago

Only if they attempt to add additional biome files by editing an existing one - your program does not recognize any but the standard 4 files that came with it. I forgot to remove the edited file from the biome folder before running Amidst, and it errored out. Removing the edited file fixed the load error.

From: "Treer" notifications@github.com To: "Treer/amidstest" amidstest@noreply.github.com Cc: "KCoombes67" kcoombes@centurylink.net, "Author" author@noreply.github.com Sent: Friday, April 20, 2018 3:09:13 AM Subject: Re: [Treer/amidstest] Solved (#5)

Sorry, what was this?

It was solved before I saw it, was it anything that might affect/help other people?

— You are receiving this because you authored the thread. Reply to this email directly, [ https://github.com/Treer/amidstest/issues/5#issuecomment-383002790 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AkUCGP3dPpJVu8FsyMjDahhw2Y3o2frpks5tqYmZgaJpZM4Tahxf | mute the thread ] .

Treer commented 6 years ago

Editing an existing biome file should work, there must be an error in the file. I'll make up some bad files and try to make sure the error is better handled.

It's not limited to the 4 standard files.

Treer commented 6 years ago

If you still have the edited biome file, I'd be curious to see it - to check what the formatting issue was and whether it can be handled better.

KCoombes67 commented 6 years ago

From: "Treer" notifications@github.com To: "Treer/amidstest" amidstest@noreply.github.com Cc: "KCoombes67" kcoombes@centurylink.net, "Author" author@noreply.github.com Sent: Friday, April 20, 2018 9:32:11 PM Subject: Re: [Treer/amidstest] Solved (#5)

If you still have the edited biome file, I'd be curious to see it - to check what the formatting issue was and whether it can be handled better.

— You are receiving this because you authored the thread. Reply to this email directly, [ https://github.com/Treer/amidstest/issues/5#issuecomment-383257668 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AkUCGJh4z9oEfdVeOmwjQRq9ri9_Hp_Wks5tqowbgaJpZM4Tahxf | mute the thread ] .

Treer commented 6 years ago

I think your reply/attachment was lost - try replying directly on github rather than via email.

KCoombes67 commented 6 years ago

Haven for Amidst.zip wouldn't let me attach as MT file, so zipped

Treer commented 6 years ago

Thanks for that. The latest version of Amidstest will read your Haven file now.

FWIW the problem was a comma after the last biome in the list - at the end of line 23. It was creating an empty biome at the end of the list.

When you're happy with Haven for Amidst.mt, would you be interested in adding it to the wiki with a link or description about what Haven is? (unless Haven is something private)

KCoombes67 commented 6 years ago

Ironically, I have the same problem when coding mods :) I'd be happy to add to your wiki, if I ever get Haven up and running. I plan to use Amidst to save myself a ton of time finding a nice mapseed.

From: "Treer" notifications@github.com To: "Treer/amidstest" amidstest@noreply.github.com Cc: "KCoombes67" kcoombes@centurylink.net, "Author" author@noreply.github.com Sent: Friday, April 27, 2018 11:33:32 PM Subject: Re: [Treer/amidstest] Solved (#5)

The latest version of Amidstest will read your Haven file now.

FWIW the problem was a comma after the last biome in the list - at the end of line 23.

When you're happy with Haven for Amidst.mt , would you be interested in [ https://github.com/Treer/amidstest/wiki/Get-more-biome-profiles | adding it to the wiki ] with a link or description about what Haven is?

— You are receiving this because you authored the thread. Reply to this email directly, [ https://github.com/Treer/amidstest/issues/5#issuecomment-385136746 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AkUCGGJzW7MQx-9pe-t3lLEDVzQ4-lRZks5ts-MMgaJpZM4Tahxf | mute the thread ] .

Treer commented 6 years ago

A haunted biome sounds very intriguing/flavoursome.

KCoombes67 commented 6 years ago

I plan to add night-spawning mobs to that biome - perhaps with rare item drops

From: "Treer" notifications@github.com To: "Treer/amidstest" amidstest@noreply.github.com Cc: "KCoombes67" kcoombes@centurylink.net, "Author" author@noreply.github.com Sent: Saturday, April 28, 2018 10:31:00 PM Subject: Re: [Treer/amidstest] Solved (#5)

A haunted biome sounded very intriguing/flavoursome.

— You are receiving this because you authored the thread. Reply to this email directly, [ https://github.com/Treer/amidstest/issues/5#issuecomment-385220684 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AkUCGKfkTtK1Emui2g-FjGt4e456gcMFks5ttSXkgaJpZM4Tahxf | mute the thread ] .