search

Treferwynd / transmission-remote-gtk

Automatically exported from code.google.com/p/transmission-remote-gtk
GNU General Public License v2.0
0 stars 0 forks source link

Cannot add torrent file #145

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Just started with recent series of patches (last 2 days): I cannot add a 
torrent file, though add-link still works.

I receive "invalid or corrupt torrent file" error on every file.  Result of 
magnet support?

Original issue reported on code.google.com by reardo...@gmail.com on 3 Oct 2011 at 3:46

GoogleCodeExporter commented 9 years ago

Original comment by a...@eth0.org.uk on 3 Oct 2011 at 7:49

GoogleCodeExporter commented 9 years ago 
in is_url(), I guess there's still a chance that any file that starts with 
"http" will not work.  So try:

regex("^http[s]?://")

instead?

Original comment by reardo...@gmail.com on 3 Oct 2011 at 1:27

GoogleCodeExporter commented 9 years ago 
Just tested, I don't think it's fixed.  Now I'm getting:

** Message: Connected to Transmission 2.33 (12563), getting torrents...

** ERROR **: TORRENTFILENAME.torrent does not exist

Program received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=0x0, log_level=<optimized out>, format=0x43e6a6 "%s does not 
exist", args1=0x7fffffffcee8)
    at /build/buildd/glib2.0-2.30.0/./glib/gmessages.c:577
577     /build/buildd/glib2.0-2.30.0/./glib/gmessages.c: No such file or 
directory.
        in /build/buildd/glib2.0-2.30.0/./glib/gmessages.c
(gdb) info thread
  Id   Target Id         Frame 
  4    Thread 0x7fffee183700 (LWP 9479) "transmission-re" pthread_cond_wait@@GLIBC_2.3.2 ()
    at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:162
  3    Thread 0x7fffee984700 (LWP 9478) "transmission-re" pthread_cond_wait@@GLIBC_2.3.2 ()
    at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:162
  2    Thread 0x7fffef185700 (LWP 9477) "transmission-re" pthread_cond_wait@@GLIBC_2.3.2 ()
    at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:162
* 1    Thread 0x7ffff7fc9940 (LWP 9474) "transmission-re" g_logv 
(log_domain=0x0, log_level=<optimized out>, format=0x43e6a6 "%s does not 
exist", 
    args1=0x7fffffffcee8) at /build/buildd/glib2.0-2.30.0/./glib/gmessages.c:577
(gdb) bt
#0  g_logv (log_domain=0x0, log_level=<optimized out>, format=0x43e6a6 "%s does 
not exist", args1=0x7fffffffcee8)
    at /build/buildd/glib2.0-2.30.0/./glib/gmessages.c:577
#1  0x00007ffff5ab16a2 in g_log (log_domain=<optimized out>, 
log_level=<optimized out>, format=<optimized out>)
    at /build/buildd/glib2.0-2.30.0/./glib/gmessages.c:591
#2  0x0000000000436c05 in trg_parse_torrent_file (filename=0x1d0d560 
"TORRENTFILENAME.torrent")
    at trg-file-parser.c:117
#3  0x000000000043572e in trg_torrent_add_dialog_set_filenames (d=0x886230, 
filenames=0x1d0aa00) at trg-torrent-add-dialog.c:721
#4  0x0000000000435f74 in trg_torrent_add_dialog_constructor (type=29423344, 
n_construct_properties=5, construct_params=0x1216f50)
    at trg-torrent-add-dialog.c:872
#5  0x00007ffff5f73e94 in g_object_newv (object_type=<optimized out>, 
n_parameters=30734720, parameters=<optimized out>)
    at /build/buildd/glib2.0-2.30.0/./gobject/gobject.c:1493
#6  0x00007ffff5f74d66 in g_object_new_valist (object_type=29423344, 
first_property_name=<optimized out>, var_args=0x7fffffffd338)
    at /build/buildd/glib2.0-2.30.0/./gobject/gobject.c:1610
#7  0x00007ffff5f75074 in g_object_new (object_type=29423344, 
first_property_name=0x43e635 "filenames")
    at /build/buildd/glib2.0-2.30.0/./gobject/gobject.c:1325
#8  0x0000000000436635 in trg_torrent_add_dialog_new (parent=0x6d41f0, 
client=0x69f830, filenames=0x1d0aa00) at trg-torrent-add-dialog.c:997
#9  0x000000000040e96a in trg_add_from_filename (win=0x6d41f0, uris=0x867dc0) 
at trg-main-window.c:396
#10 0x000000000040d0dd in message_received_cb (app=0x678190, command=1, 
message=0x1bb7830, time_=1317659647, user_data=0x6d41f0) at main.c:71
#11 0x00007ffff74f6f10 in unique_marshal_ENUM__INT_BOXED_UINT () from 
/usr/lib/libunique-1.0.so.0
#12 0x00007ffff5f6e0a4 in g_closure_invoke (closure=0x891530, 
return_value=0x7fffffffd6c0, n_param_values=4, param_values=0x7a51e0, 
    invocation_hint=<optimized out>) at /build/buildd/glib2.0-2.30.0/./gobject/gclosure.c:774
#13 0x00007ffff5f8002a in signal_emit_unlocked_R (node=<optimized out>, 
detail=0, instance=0x678190, emission_return=0x7fffffffd820, 
    instance_and_params=0x7a51e0) at /build/buildd/glib2.0-2.30.0/./gobject/gsignal.c:3272
#14 0x00007ffff5f89483 in g_signal_emit_valist (instance=<optimized out>, 
signal_id=<optimized out>, detail=<optimized out>, var_args=<optimized out>)
    at /build/buildd/glib2.0-2.30.0/./gobject/gsignal.c:3013
#15 0x00007ffff5f89852 in g_signal_emit (instance=<optimized out>, 
signal_id=<optimized out>, detail=<optimized out>)
    at /build/buildd/glib2.0-2.30.0/./gobject/gsignal.c:3060
#16 0x00007ffff74f5454 in unique_app_emit_message_received () from 
/usr/lib/libunique-1.0.so.0
#17 0x00007ffff74f8652 in ?? () from /usr/lib/libunique-1.0.so.0
#18 0x00007ffff74f876f in ?? () from /usr/lib/libunique-1.0.so.0
#19 0x00007ffff4d0a77f in invoke_object_method (message=0x699b30, 
connection=0x6995f0, method=0x7ffff76fbd70, object_info=0x1ab4a60, object=0x1)
    at dbus-gobject.c:1744
#20 object_registration_message (connection=0x6995f0, message=0x699b30, 
user_data=<optimized out>) at dbus-gobject.c:1968
#21 0x00007ffff0595ae1 in _dbus_object_tree_dispatch_and_unlock (tree=0x6992b0, 
message=0x699b30) at ../../dbus/dbus-object-tree.c:858
---Type <return> to continue, or q <return> to quit---
#22 0x00007ffff05879d0 in dbus_connection_dispatch (connection=0x6995f0) at 
../../dbus/dbus-connection.c:4644
#23 0x00007ffff4d08395 in message_queue_dispatch (source=<optimized out>, 
callback=<optimized out>, user_data=<optimized out>) at dbus-gmain.c:90
#24 0x00007ffff5aa8a5d in g_main_dispatch (context=0x694a90) at 
/build/buildd/glib2.0-2.30.0/./glib/gmain.c:2441
#25 g_main_context_dispatch (context=0x694a90) at 
/build/buildd/glib2.0-2.30.0/./glib/gmain.c:3011
#26 0x00007ffff5aa9258 in g_main_context_iterate (context=0x694a90, 
block=<optimized out>, dispatch=1, self=<optimized out>)
    at /build/buildd/glib2.0-2.30.0/./glib/gmain.c:3089
#27 0x00007ffff5aa9792 in g_main_loop_run (loop=0x8fd190) at 
/build/buildd/glib2.0-2.30.0/./glib/gmain.c:3297
#28 0x00007ffff6fe8da7 in IA__gtk_main () at 
/build/buildd/gtk+2.0-2.24.6/gtk/gtkmain.c:1329
#29 0x000000000040d3ca in main (argc=1, argv=0x7fffffffe188) at main.c:170

Original comment by reardo...@gmail.com on 3 Oct 2011 at 4:37

GoogleCodeExporter commented 9 years ago 
in trg_parse_torrent_file() should be:

    !g_file_test(filename, G_FILE_TEST_IS_REGULAR)

Original comment by reardo...@gmail.com on 3 Oct 2011 at 5:28

GoogleCodeExporter commented 9 years ago 
Also note that if you pass garbage via the commandline trg will crash.  Needs 
an earlier existence check, all the way back in main()

Original comment by reardo...@gmail.com on 3 Oct 2011 at 5:30