Column sorting broken

[GoogleCodeExporter]

This repro's on two different KDE machines, using r327 build.  I can no longer 
sort the main view by clicking on column header.

Original issue reported on code.google.com by reardo...@gmail.com on 28 Nov 2011 at 5:49

[GoogleCodeExporter]

Note that other tree views are still sortable, for instance the files list is 
remains ok.

Original comment by reardo...@gmail.com on 28 Nov 2011 at 5:50

[GoogleCodeExporter]

Thanks for reporting, this should be fixed now. For the main view I changed the 
sort model feeding off the filter model to the other way around, which fixed a 
nasty refiltering crash I've wanted to get rid of for a while.

Unfortunately GtkTreeFiltered isn't GtkTreeSortable, so I've had to make a 
subclass which passes on the GtkTreeSortable functions to the child model. 

Original comment by a...@eth0.org.uk on 29 Nov 2011 at 9:31

• Changed state: Fixed

[GoogleCodeExporter]

Sorting is fixed, however I noticed that the up/down indicator is not visible 
in the main view, while it is visible in the files tree view, among others.

Original comment by reardo...@gmail.com on 29 Nov 2011 at 2:18

[GoogleCodeExporter]

Oops, good thing you notice these things. :-)

Fixed now. Looking at the GTK code, saw that GtkTreeViewColumn connects up to 
the sort-column-changed event and uses this to maintain its own index/order. If 
this doesn't match with the model = no indicators. Just needed to proxy this 
event from the real sortable through the new model class.

Original comment by a...@eth0.org.uk on 29 Nov 2011 at 9:04

[GoogleCodeExporter]

It's mostly fixed, but there is an odd hiccup.  It seems to have three states 
now, sorted-up, sorted-down, and not-sorted (in this last, the ID becomes the 
sort field, though this is not visually indicated).  Odd.

Original comment by reardo...@gmail.com on 29 Nov 2011 at 9:12

[GoogleCodeExporter]

Yeah, odd, I really can't see anything that the GTK sortable model class does 
that mine should do which would cause this. I'll try to figure this out 
sometime I guess.

Just from my impression, changing the filters seems faster now and scrolling in 
the torrent tree view (holding the down key). Maybe because it doesn't have to 
resort after the filtering.

Original comment by a...@eth0.org.uk on 29 Nov 2011 at 10:00