Treferwynd / transmission-remote-gtk

Automatically exported from code.google.com/p/transmission-remote-gtk
GNU General Public License v2.0
0 stars 0 forks source link

GTK3 build is rather broken #176

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
using the r408 code, on KDE, this build is fairly well broken.  App just locks 
up.  But more imoprtantly, it ignores the gtk-kde mappings that are observed by 
GTK2 apps so you end up with crude looking decorations..  As far as I know, 
that support is not yet enabled in GTK3.

I cannot tell easily how to force it back to GTK2 build?

Original issue reported on code.google.com by reardo...@gmail.com on 19 Jan 2012 at 3:36

GoogleCodeExporter commented 9 years ago
There is no mouse support.

Original comment by reardo...@gmail.com on 19 Jan 2012 at 3:37

GoogleCodeExporter commented 9 years ago
make now fails, even with GTK3 removed completely.  'configure' detected this 
and switched to GTK2, but build fails:

make  all-recursive
make[1]: Entering directory `/home/.../bin/transmission-remote-gtk'
Making all in src
make[2]: Entering directory `/home/.../bin/transmission-remote-gtk/src'
  CC     main.o
main.c: In function ‘main’:
main.c:215:5: warning: implicit declaration of function ‘convert_args’ 
[-Wimplicit-function-declaration]
main.c:215:20: warning: initialization makes pointer from integer without a 
cast [enabled by default]
main.c: At top level:
main.c:253:16: error: conflicting types for ‘convert_args’
main.c:215:20: note: previous implicit declaration of ‘convert_args’ was 
here
main.c:253:16: warning: ‘convert_args’ defined but not used 
[-Wunused-function]
make[2]: *** [main.o] Error 1
make[2]: Leaving directory `/home/.../bin/transmission-remote-gtk/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/.../bin/transmission-remote-gtk'
make: *** [all] Error 2

Original comment by reardo...@gmail.com on 19 Jan 2012 at 3:44

GoogleCodeExporter commented 9 years ago
When does it lock up? Load/connect/select/update? It seemed to work well for me 
on Fedora 16 and Ubuntu 11.04 Unity.

I've disabled GTK3 support for now, by commenting out some bits in configure.ac.

Hopefully I just fixed that problem on GTK2. Again it works for me, but I think 
that function just needed moving before the call.

Original comment by a...@eth0.org.uk on 19 Jan 2012 at 4:47

GoogleCodeExporter commented 9 years ago
GTK2 build is back up (r409).

I really recommend that you have a KDE distribution installed in a VM or 
somesuch as the problems I am seeing are myriad and not easily describable (by 
me, anyway).  I can't yet tell where it locks up or why the mouse is 
sporadically available, or why the decorator fails, etc.  I've tried running 
with and without an explicit GTK3 decorator (unico).

Just noticed that autoconnect no longer works in GTK3.

I do not yet know of a KDE-based distribution that also properly configures 
GTK3, so I think for now it is a non-starter.  GTK2 apps run smoothly on KDE of 
course (see: firefox, chrome), but lots of integration work was required for 
that.

Is it possible to have a gtk2 vs. gtk3 option in configure.ac, to allow 
override of auto-detection?  

I strongly recommend against moving to GTK3 for your own builds (hosted here 
and at launchpad).

Original comment by reardo...@gmail.com on 19 Jan 2012 at 5:02

GoogleCodeExporter commented 9 years ago

Original comment by a...@eth0.org.uk on 22 Jan 2012 at 4:59