Completed torrents with incomplete progress bar

[GoogleCodeExporter]

transmission-remote-gtk svn version compiled today
Ubuntu 12.04 64 bits
Gnome-shell 3.4.1

I have one download torrent and several complete torrents in seeding state.
transmission-remote-gtk shows the same progress bar and percentage of this 
seeding torrents than the download torrent.
See the attached picture for more details.

Original issue reported on code.google.com by si...@j1s.es on 30 Aug 2012 at 1:40

Attachments:

• captura_0830_15:34:19.jpg

[GoogleCodeExporter]

Sorry, I forgot to say that this occurs with both Transmission-style views.

Original comment by si...@j1s.es on 30 Aug 2012 at 1:43

[GoogleCodeExporter]

Hi Simon,

I've just made a change I think *might* fix it, but I wasn't really able to 
reproduce to confirm.

Is a seed ratio enabled on those two torrents or globally? I notice it thinks 
the goal is 0.00, which I presume is wrong. If it's the bug I think I've fixed, 
you have the target ratio set to an integer and it's mangling that into a 
double.

Let me know if you have any other problems with the new stuff, it's a lot of 
new code so may have other bugs. :o)

Original comment by a...@eth0.org.uk on 30 Aug 2012 at 7:49

[GoogleCodeExporter]

Ok, the goal problem is solved now, yes my target ratio is an integer: 4. (I 
attach one screenshot)
But the progress bar is confuse. Visually it seems that the torrent isn't 
finalized.
In Transmission-web it uses colors in progress bar to differentiate states. Can 
you change the colors of progress-bar in GTK?

Original comment by si...@j1s.es on 30 Aug 2012 at 8:15

Attachments:

• captura_0830_22:07:28.jpg

[GoogleCodeExporter]

I see what you mean on the WebUI, there's no way to do this with the 
GtkProgressCellRenderer. My aim is to replicate the Transmission GTK look, for 
now at least.

I've just compared with it and found two differences.. Removed the text in the 
progress bar, and the full seeds were being displayed as partial seeds (eg. 2gb 
of 2gb) and vice versa. Now this is fixed I think it all looks the same.

Original comment by a...@eth0.org.uk on 30 Aug 2012 at 9:33

• Changed state: Fixed

[GoogleCodeExporter]

I attach one screenshot with the actual changes. It's difficult to see which 
torrents are seeding and which downloading. 
One way to differentiate this easily it could be show the text in progress bar 
when it downloads and hide it when it seeds.

By other side, I don't know programming in C but I've consulted the Gnome 
developers guide of 'GtkCellRendererProgress' 
(http://developer.gnome.org/gtk/2.24/GtkCellRendererProgress.html) and I see 
that it inherits from 'GtkCellRenderer' and this object has the property 
'cell-background-gdk' that, I think, it allows change the color of progress bar.
In GTK3 (http://developer.gnome.org/gtk3/stable/GtkCellRendererProgress.html) 
the property 'cell-background-gdk' exists too but it's deprecated 
(http://developer.gnome.org/gtk3/stable/GtkCellRenderer.html#GtkCellRenderer--ce
ll-background-gdk) and it recommends use 'cell-background-rgba' 
(http://developer.gnome.org/gtk3/stable/GtkCellRenderer.html#GtkCellRenderer--ce
ll-background-rgba)

I have found these others links (I hope that it helps you):
https://mail.gnome.org/archives/gtk-app-devel-list/2012-June/msg00086.html
http://ometer.com/gtk-colors.html
http://developer.gnome.org/gtk3/stable/gtk-question-index.html (question 3.1)
http://osdir.com/ml/gtk-app-devel-list/2010-08/msg00014.html

Original comment by si...@j1s.es on 31 Aug 2012 at 1:22

Attachments:

• captura_0831_14:36:50.jpg

[GoogleCodeExporter]

Another possible solution could be change the color of torrent name when 
Transmission style according to state.

Original comment by si...@j1s.es on 1 Sep 2012 at 11:05

[GoogleCodeExporter]

I open another issue because this is closed and the theme isn't exactly the 
same.

Original comment by si...@j1s.es on 1 Sep 2012 at 11:07