Treferwynd / transmission-remote-gtk

Automatically exported from code.google.com/p/transmission-remote-gtk
GNU General Public License v2.0
0 stars 0 forks source link

With Transmission style is difficult to distinguish the states of the torrent. #215

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Transmission svn version compiled today
Ubuntu 12.04 64 bits
Gnome-shell 3.4.1

With Transmission style is difficult to distinguish the states of the torrent. 
The progress bar is the same color for all states. Visually it seems that all 
torrents aren't finalized.
In Transmission-web it uses colors in progress bar to differentiate states. Can 
you change the colors of progress-bar in GTK?

It's difficult to see which torrents are seeding and which downloading. 
One way to differentiate this easily it could be show the text in progress bar 
when it downloads and hide it when it seeds.

Another possible solution could be change the color of torrent name when 
Transmission style according to state.

I don't know programming in C but I've consulted the Gnome developers guide of 
'GtkCellRendererProgress' 
(http://developer.gnome.org/gtk/2.24/GtkCellRendererProgress.html) and I see 
that it inherits from 'GtkCellRenderer' and this object has the property 
'cell-background-gdk' that, I think, it allows change the color of progress bar.
In GTK3 (http://developer.gnome.org/gtk3/stable/GtkCellRendererProgress.html) 
the property 'cell-background-gdk' exists too but it's deprecated 
(http://developer.gnome.org/gtk3/stable/GtkCellRenderer.html#GtkCellRenderer--ce
ll-background-gdk) and it recommends use 'cell-background-rgba' 
(http://developer.gnome.org/gtk3/stable/GtkCellRenderer.html#GtkCellRenderer--ce
ll-background-rgba)

I have found these others links (I hope that it helps you):
https://mail.gnome.org/archives/gtk-app-devel-list/2012-June/msg00086.html
http://ometer.com/gtk-colors.html
http://developer.gnome.org/gtk3/stable/gtk-question-index.html (question 3.1)
http://osdir.com/ml/gtk-app-devel-list/2010-08/msg00014.html

Thanks for your work. Regards.

Original issue reported on code.google.com by si...@j1s.es on 1 Sep 2012 at 11:11

Attachments:

GoogleCodeExporter commented 9 years ago
One thing I did on the recently released stable version is to modify the 
progress renderer to invert the progress bar when a torrent is seeded. This 
only works on the full and compact Transmission views. One caveat is that this 
requires gtk 3.2+ as the earlier versions had a bug which I reported to them 
and was later fixed. This was in the official gtk client of Transmission for 
awhile then got dropped when they started merging in gtk3.

The only other thing I am missing is displaying the current ratio while 
downloading.

Attached is the over-simplified version that I am presently using.

Original comment by valli...@gmail.com on 18 Sep 2012 at 2:13

Attachments:

GoogleCodeExporter commented 9 years ago
I've tested it in Ubuntu 12.04 and it works well. 
Of course, a better solution would change colors for each state. 
But this simple solution is better than now.
Thanks.

Original comment by si...@j1s.es on 18 Sep 2012 at 4:43

GoogleCodeExporter commented 9 years ago
I didn't want to try to mess with text or cell colours since those should be 
left to the theme. However, I did modify the patch so that it will apply a 
slant to the torrent name when seeding. I cannot really tell the difference 
between italics and oblique with the font I am using, so feel free to change 
them around however. I do not apply the styling to paused/finished torrents, so 
those will appear as usual.

If you still cannot tell at a glance what is seeding or not with this then I 
dunno...

Original comment by valli...@gmail.com on 19 Sep 2012 at 5:35

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, this is better.
Regards.

Original comment by si...@j1s.es on 19 Sep 2012 at 10:25

GoogleCodeExporter commented 9 years ago
I updated my patch to fix an issue I noticed, the variable I was using is set 
to false when you aren't using a seedratio so the display wasn't correct. Added 
a new variable to check against the actual state.

Original comment by valli...@gmail.com on 22 Sep 2012 at 2:59

Attachments: