Treferwynd / transmission-remote-gtk

Automatically exported from code.google.com/p/transmission-remote-gtk
GNU General Public License v2.0
0 stars 0 forks source link

Gtk menubar does not go to the end of the window #249

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The menubar really does not look right. It looks like it is in a vertical box 
that has a margin set on it.

*) What steps will reproduce the problem?
1. Load the application.

*) What is the expected output? What do you see instead?
The menu bar would look better going all the way to the edge of the window. 
Maybe set the main box with no margin and put another one inside that with a 
margin for the content and status bar?

*) What version of the product are you using? On what operating system?
1.1.1 on Ubuntu 13.10 (with global menus disabled)

*) Please provide any additional information below.
Everything else is great, Love your work :)

Original issue reported on code.google.com by b...@mpshouse.com on 27 Jan 2014 at 9:22

Attachments:

GoogleCodeExporter commented 9 years ago
I found a 2px margin on the outside vbox that I removed, can you try with the 
git master?

Original comment by a...@eth0.org.uk on 31 Jan 2014 at 1:12

GoogleCodeExporter commented 9 years ago
Found another 6px padding, not sure why that was there. Removed that too.

Original comment by a...@eth0.org.uk on 31 Jan 2014 at 1:18

GoogleCodeExporter commented 9 years ago
I compiled the source from git and there is no change in the menu bar. It still 
looks like the screen shot I uploaded previously.

I downloaded the source using "git clone 
https://code.google.com/p/transmission-remote-gtk/"

Original comment by b...@mpshouse.com on 31 Jan 2014 at 10:34

GoogleCodeExporter commented 9 years ago
Sorry, I pushed to github (which is mainly needed for the ubuntu PPA) instead 
of google.

I've pushed these changes to google now. Can you try again?

Original comment by a...@eth0.org.uk on 1 Feb 2014 at 10:57

GoogleCodeExporter commented 9 years ago
Yes the menubar looks good now. I added 5 padding to either side of the 
toolbarHbox which looked good. I would have like to have added a 5 left and 
right margin to vpaned but I do not know GTK+ well, I code Gtkmm. I have been 
working on a project like this for utorrent Linux server 
(http://blog.mpshouse.com/?p=913) but would like to port this to Gtkmm instead 
if it is OK, just for some fun as I do not use utorrent anymore.

Thanks for your hard work on this. It is a great project and your source looks 
great and easy to read.

Original comment by b...@mpshouse.com on 1 Feb 2014 at 12:16

GoogleCodeExporter commented 9 years ago
Thanks :) I think if you want to add padding to any GTK widget, try using a 
GtkAlignment.

Your project looks interesting, good luck with it.

Original comment by a...@eth0.org.uk on 1 Feb 2014 at 1:44