Treferwynd / transmission-remote-gtk

Automatically exported from code.google.com/p/transmission-remote-gtk
GNU General Public License v2.0
0 stars 0 forks source link

Add torrent dialog not brought into focus #260

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
On arch Linux, and both with the GTK2 and GTK3 builds available from 
respectively

https://aur.archlinux.org/packages/transmission-remote-gtk/

and

https://aur.archlinux.org/packages/transmission-remote-gtk2/

the "Add Torrent" dialog that I have selected to appear on add in the options 
is not brought into focus; disappears behind my browser window. I've already 
had a few torrent hang around indefinitely due to this. Is it a build-issue, or 
could the program add some explicit "bring me into focus" command when opening 
that dialog? 

Original issue reported on code.google.com by rene.her...@gmail.com on 21 Apr 2014 at 7:47

GoogleCodeExporter commented 9 years ago
Added a call to gtk_window_present, hopefully fixed. Please confirm.

Original comment by a...@eth0.org.uk on 25 Apr 2014 at 6:34

GoogleCodeExporter commented 9 years ago
Confirmed. Backported to 1.1.1 and tested with both the GTK2 and GTK3 
arch-builds; the dialog is presented both when transmission-remote-gtk was and 
when it wasn't already running. Great.

... and I fact believe that your client should, assuming you'd not be against 
this, be adopted back into transmission itself; it's somewhat silly that 
currently the official qt client CAN function as a remote client, and the 
official GTK one cannot. Given that I always thought of Transmission as 
primarily a GTK client, I know that made at least me go, "huh?"

Anyways. Thanks for a nice client, for enabling a nice local transmission 
setup, and for a nice bug-chasing experience.

Original comment by rene.her...@gmail.com on 25 Apr 2014 at 9:07

GoogleCodeExporter commented 9 years ago
Actually, it seems something's still lingering...

Just had the add dialog disappear behind my browser, firefox, again (with the 
GTK2 version, which is the version I normally run). After rebuilding the 
package to make vewy, vewy sure that I was running with this patch... I can't 
reproduce it anymore. I was however in fact already qwuite, qwuite sure that I 
WAS running with this patch before as well, so perhaps there's still some 
missing spot.

If/when I get a better diagnosis, I'll follow-up again.

Original comment by rene.her...@gmail.com on 26 Apr 2014 at 7:33

GoogleCodeExporter commented 9 years ago
Are you sure you're running the latest git (with the fix), and GTK2?

I removed support for GTK2 a while back. Why do you prefer GTK2 out of interest?

Original comment by a...@eth0.org.uk on 27 Apr 2014 at 11:26

GoogleCodeExporter commented 9 years ago
No, I'm running stock 1.1.1 with both issues "backported", as per the attached. 
Issue 259 is a straight apply, issue 260 had some offsets -- but I believe that 
should be right as attached. When I tried current git (above) at least its 
classic view bombed out totally so I thought I'd not muddy things up...

GTK2 indeed; I'm using

https://aur.archlinux.org/packages/transmission-remote-gtk2/

with only those two added patches. I prefer GTK2 due to recently having started 
to run the MATE desktop environment which in its current version is still GTK2. 
It's being ported to GTK3 but not there yet.

Arch Linux recently officially started to support MATE, and I believe you/we 
might see a significant uptake of that environment in the near future, 
especially given the stand-still that Xfce seems to have come to -- which it 
sort of seems to obsolete anyway. MATE is just the thing that us "non-bloated 
yet quite functional desktop on legacy hardware" users would appreciate...

Of course, it's not a huge problem to run the GTK3 version -- I'm running more 
GTK3 apps in this environment. But given the choice, GTK2 is still the logical 
one in MATE.

And I believe I've identified the remaining "add-dialog behind browser-window" 
case: it happens when I explicitly download the torrent file, then run it from 
the firefox "all downloads" lists. I would not have a single clue as to how 
"running" a torrent that way would result in a different call to 
transmission-remote-gtk than when running it directly without explicitly 
downloading it first... but perhaps you would?

Original comment by rene.her...@gmail.com on 28 Apr 2014 at 12:03

Attachments:

GoogleCodeExporter commented 9 years ago
You may need to ignore this. Just now the add dialog "randomly" hid itself 
behind my browser on 1 of 3 subsequent torrent downloads from the same site, 
downloaded in the same manner; I can't find the logic behind this issue. If and 
when I ever do, I'll follow up -- but I won't be holding my breath.

Original comment by rene.her...@gmail.com on 29 Apr 2014 at 8:16