Trekiros / battleSim

A simple encounter simulator for TTRPG battles, to help game master plan fun games.
battlesim-zeta.vercel.app
50 stars 19 forks source link

Attack crit chance and crit damage #22

Open pero5ar opened 3 weeks ago

pero5ar commented 3 weeks ago

Is your feature request related to a problem? Please describe. Somewhat recently I've added crit damage into the calculator. While useful for damage rolls that have >2 dice, it does not solve the main scenario I'd like to simulate, which is a "half-orc fighter with great sword crit at 19".

Crit at 19 (and later 18) is the key feature of the Champion Fighter, and there are a few other features that offer the same behaviour for a more limited time but are impactful for one encounter (e.g. Hexblade Warlock can curse one target and get cri tat 19 for that target). Half-orcs also get an extra damage dice on melee weapon attacks crits which does not seem like much, but stacks nicely when crit chance is higher and extra attack is a thing. While still a small sample size, this specific half-orc champion has ended up having a much bigger impact in the encounters I ran than it did in the simulation.

Additionally, getting advantage on an attack (which is a common tactic for rouges) means that there is a 9.75% chance to roll a 20 which is approximate to the 10% chance to roll at least a 19. While advantage should be dealt as its own thing if ever implemented in the future, a good temporary workaround would be to:

  1. duplicate an attack
  2. set the attack to be something other than at will (e.g. every 2 rounds)
  3. set a higher to hit chance (an extra +3 or +5) and set "crit at 19"

This would more or less match the math of an attack with advantage.

Describe the solution you'd like Add the following fields to attack actions:

[1] This crit damage field has the additional benefit of being an input that can be used attacks that use flat averages instead of dice rolls.

Describe alternatives you've considered I've toyed with making a separate "Crit attack" action that has a lower hit chance but higher damage output, but it's finicky to get the simulation to use this and even when it does the average damage would be lower as it does not have the non-crit damage in the calculation.