Trenchbroom crashes after clicking "entities" tab when making Daikatana map

[Sinihopea]

System Information

OS: openSUSE 15.0 Kernel: x86_64 Linux 4.12.14-lp150.12.22-default Packages: 3342 Shell: zsh 5.6.2 Resolution: 1600x900 DE: XFCE4 WM: Xfwm4 CPU: Intel Core i5-3230M @ 4x 3.2GHz [58.0°C] RAM: 3484MiB / 7789MiB

This is an Optimus Thinkpad T430 with NVS 5400m and Intel HD4000.

I've witnessed this behaviour occur in both the downloadable RC3b package as well as in current "release/2.1.0" branch commit "d70404bb85a2ef5926b66f9eb4648c6b68498023". It wasn't an issue in RC1 release.

Expected Behavior

Entities tab opens up and Trenchbroom will not crash.

Steps to Reproduce

• Open new map for Daikatana.
• Click "Entities" tab.
• Crash will occur.

Crash Info

trenchbroom-crash-11.log trenchbroom-crash-11.txt

[kduske]

@Sinihopea We are debating again about palette loading in Daikatana. From what I can gather, the palettes are handled as follows.

• skin textures use the palette embedded in the wal file
• level textures do not use the embedded palettes at all
• if a palette worldspawn property is set, then its value determines the path of the palette to use: /textures/$palette/colormap.bmp, whereby $palette is the value of the palette worldspawn entity property
• if no such worldspawn property is set, then the palette is loaded from /pics/colormap.bmp

I have changed the behavior to match what is described above, and I hope that is in line with the game's behavior. The consequence is however that the textures will look wrong unless the palette key is set correctly and the user reloads the textures. Furthermore, adding more than one texture directory can be problematic with Daikatana because the palettes may be incompatible.