search

TrenchBroom / TrenchBroom

Cross-Platform Level Editor
kristianduske.com/trenchbroom
GNU General Public License v3.0
1.88k stars 224 forks source link

Fix uniform name mixups. #4563

Closed dsvensson closed 4 days ago

dsvensson commented 1 week ago

Would otherwise crash when going to entity browser, or material browser respectively.

dsvensson commented 1 week ago

A fun safeguard for this would be to hack something up with libtooling that checks what shader such calls are made towards, and scrape the uniforms from the shaders and run that as a part of the CI - or more connected, generate shader constants at build time that's used by the code, but I guess they're generally fairly static.

kduske commented 1 week ago

I don't think it's worth it. It's not like an error such as this has happened often, let alone made it into a release.