search

Trendyol / Jdempotent

Make your consumer, API, etc. idempotent easily.
MIT License
100 stars 25 forks source link

Hotfix save response in redis. #37

Closed SawCunha closed 2 years ago

SawCunha commented 2 years ago

Fix when saving response in redis. Before there was no saving with this the return was null of the Response data.

memojja commented 2 years ago

Hi @SawCunha,

Good catch. thanks for that but I did not see any test case, could you please add test scenario

SawCunha commented 2 years ago

Hi @memojja I added the test scenarios for this fix.

memojja commented 2 years ago

Hi @SawCunha ,

Thanks again. Can you upgrade the version in Jdempotent-core, Jdempotent-spring-boot-redis-starter and Jdempotent-spring-boot-couchbase-starter project version 1.0.11 to 1.0.12? Then we can merge that pr 👨‍💻

SawCunha commented 2 years ago

Hi @memojja I upgraded the version to 1.0.12. Thanks.

memojja commented 2 years ago

Thanks again. Maven central sync consume ~12 hour. And later i will update readme file. you can track that readme or following repository link

https://mvnrepository.com/artifact/com.trendyol/Jdempotent-spring-boot-redis-starter