search

Trendyol / baklava-react-native

https://trendyol.github.io/baklava-react-native/
MIT License
102 stars 6 forks source link

Input: The label contains text such as optional which cannot be changed by user. #56

Open mehmetranas opened 12 months ago

mehmetranas commented 12 months ago

Describe the bug The optional text in the input component should be changeable.

To Reproduce Steps to reproduce the behavior:

  1. Add a input component with required false property.
  2. Add a label title
  3. See label as "foo-lable (optional)" Expected behavior As a user, I may not want to see text like 'optional'.

Screenshots Screenshot 2023-10-09 at 17 26 13

Smartphone:

ergenekonyigit commented 12 months ago

Thanks for the issue. Currently input required/optional behaves opposite to what we expect. We discussed this situation internally, so we will change the behavior to what you expected.

aliziyacevik commented 8 months ago

Hello @ergenekonyigit, if this matter is still ongoing, I can offer my assistance.

pinarkizilarslan commented 7 months ago

Hello @aliziyacevik, a design change is being made by the designers here. We are waiting for them. We thank you for your interest.

aliziyacevik commented 7 months ago

You can always reach out to me if a hand is needed! @pinarkizilarslan . Thanks for your response.