search

Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.
https://baklava.design/
MIT License
1.24k stars 113 forks source link

Visual regression test for focus state of Radio Input #322

Open muratcorlu opened 1 year ago

muratcorlu commented 1 year ago

In the related PR I couldn't manage to run interaction tests on chromatic to get focus state screenshots. I contacted with Chromatic support and got an reply below:

Hey Murat! Thanks for your patience - I wanted to provide you with a quick update regarding the issue you reported around interaction tests. We've identified that the issue is a bug, and our Engineering team is looking into what's causing it. I'll update you once a resolution has been reached - let me know if you have any questions in the meantime! Regards, Suki

Now we are waiting for a fix on Chromatic, then we'll need to check radio input focus state screenshots.

muratcorlu commented 1 year ago

We had an answer:

Hey Murat - thanks for your patience! Our Engineers determined the reason your interaction tests are having issues showing is due to the Storybook version you're using. If you upgrade your Storybook version to 6.5.10 or later, you should see the interactions badge appear. Let me know if you have any questions or if you still experience issues after upgrading! Regards, Suki

I'll upgrade Storybook with this issue and check if it really fix the problem.