search

Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.
https://baklava.design/
MIT License
1.26k stars 112 forks source link

feat: table component #788

Closed bariskaraca closed 7 months ago

bariskaraca commented 8 months ago

Closes #142

buseselvi commented 8 months ago

Great job! 🚀 Just, I think sorting works wrong. It looks right on the UI but should be working as ascending (A-Z / 1-9) sorting on the first click. It is working as Z-A / 9-1 in the storybook. Can we fix that? 🙏 @bariskaraca

buseselvi commented 8 months ago

When there is a disabled row that can't be selected, the table header checkbox should be indeterminate. We also did that in the Select Component as in the second picture below.

image image
AykutSarac commented 7 months ago

There's an issue with the cell corners and width/height:

image
buseselvi commented 7 months ago

There's an issue with the cell corners and width/height:

image

and can we fix this radius issue, too? 🙏🏻

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 3.0.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: