fix(select): fix the issue where the popover for a disabled select can still open using keydown events

Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.

https://baklava.design/

MIT License

1.24k stars 112 forks source link

Closed erbilnas closed 5 months ago

erbilnas commented 5 months ago

Fixes #793 #792

Address issue where the popover opens when key downs are triggered while the select is disabled.
Resolve the inability to set view-select-all to false.
Fix the issue where the popover opens when search icon clicked.
Fix the issue the wrong color of item count while the select is disabled.

AykutSarac commented 5 months ago

Though it doesn't open the popover, it still highlights the select when Space key pressed.

erbilnas commented 5 months ago

Though it doesn't open the popover, it still highlights the select when Space key pressed.

I think it's beneficial to indicate to users which element they are currently on

AykutSarac commented 5 months ago

I think it's beneficial to indicate to users which element they are currently on

Users should not be able to focus on a disabled component, this is misleading.

erbilnas commented 5 months ago

The highlight issue has been resolved in the latest commit fyi

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 3.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: