Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.
https://baklava.design/
MIT License
1.24k stars 112 forks source link

Add Custom CSS Properties for Border Radius, Style, and Color to bl-button #812

Closed MehmetCanBOZ closed 4 months ago

MehmetCanBOZ commented 4 months ago

Description In split button design Figma, we need to add some CSS custom properties for borders to match with the design.

This issue aims to enhance the bl-button component's styling flexibility by introducing three new CSS custom properties:

These properties will allow developers to more easily customize the appearance of bl-button components to fit the design requirements of their projects without modifying the component's internal CSS or structure.

erbilnas commented 4 months ago

We don't need these attributes because we already have four styles: Default, Neutral, Success, and Danger. We want to enforce strictness for now in order to maintain consistency within the design system.

MehmetCanBOZ commented 4 months ago

You are right, maybe I can add a divider for the last one, but for the other ones, we can talk if they are necessary or not.

erbilnas commented 4 months ago
erbilnas commented 4 months ago

You could consider one of them as the new button inherited from our bl-button, while the other is an already existing component of bl-dropdown.