search

Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.
https://baklava.design/
MIT License
1.24k stars 112 forks source link

fix(select): fix select value bug when undefined #815

Closed omerclskn closed 3 months ago

omerclskn commented 3 months ago

This PR fixes the problem of non-valued options appearing selected in select component.

Closes #625

erbilnas commented 3 months ago

I believe it constitutes a breaking change. My mistake, I misread it

omerclskn commented 3 months ago

Sending "empty string" instead of null shoul be better. Otherwise it can break something.

empty string causes empty values to be set in single select too. my 3rd test in the test file is related to this case. so this bug is also related to single select.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 3.0.0-beta.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: