search

Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.
https://baklava.design/
MIT License
1.24k stars 112 forks source link

feat(drawer): add dynamic width feature to drawer #820

Closed erdemgonul closed 3 months ago

erdemgonul commented 3 months ago

This PR adds setting width feature into drawer.

Closes https://github.com/Trendyol/baklava/issues/767

This had to be written with JavaScript because it was previously written with @ media, and we couldn't use CSS variables inside @ media. Reference source: https://stackoverflow.com/a/40723269

Also added style-to-px-converter to give width properties like '%', 'vh'

buseselvi commented 3 months ago

Can we add a drawer example to the storybook with the custom width feature? 🙏🏻

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 3.0.0-beta.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: