Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.
https://baklava.design/
MIT License
1.26k stars 112 forks source link

[BUG]: Empty bl-select causes floating-ui to throw an error #825

Closed ogunb closed 5 months ago

ogunb commented 5 months ago

Issue description

Let's say you want to fetch options as user inputs search.

  1. Start with an empty bl-select.
  2. Click on bl-select.

The click action is going to log the error below and break popover functionality. Uncaught TypeError: Cannot read properties of null (reading 'assignedSlot')

Reproduction: https://codepen.io/ogunb/pen/yLrqrZg

This is also preventing developers to slot things other than bl-select-option into the select component, such as an error message with a custom icon. Even though this may not something we want to support, it feels like a breaking change. Maybe we should go with a css solution instead.

https://github.com/Trendyol/baklava/issues/794 https://github.com/Trendyol/baklava/pull/803

Media & Screenshots

No response

Baklava Version

3.0.0-beta.5

Operating system

No response

Priority this issue should have

Medium (should be fixed soon)

Please review the checkboxes that are applicable.

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 3.0.0-beta.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: