fix(dialog): fix nested dialog propagation problem

Trendyol / baklava

Baklava is a design system provided by Trendyol to create a consistent UI/UX for app users.

https://baklava.design/

MIT License

1.24k stars 113 forks source link

Closed BaharYilmaz closed 2 months ago

BaharYilmaz commented 2 months ago

This PR fixes the propagation issue during close in nested dialogs

Closes #342

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.0.0-beta.16 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ozkersemih commented 2 months ago

It is merged but i think this approach is not best solution because now i can not listen bl-dialog-close event like:

  window.addEventListener('bl-dialog-close',(e) => console.log(e));

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: