search

Trendyol / go-dcp

The Go implementation of the Couchbase DCP with various features
MIT License
85 stars 15 forks source link

feat: add connectionBufferSizeMB field in order to specify support mb values #70

Closed Abdulsametileri closed 1 year ago

Abdulsametileri commented 1 year ago

In the connectionBufferSize config on primary and metadata buckets, we got raw bytes value as connectionBufferSize: 20971520 it's really hard to read and understand the exact value.

To get mb related value from users like 5mb, 15mb, 1.5mb, 2.5mb etc. I have added a new field called connectionBufferSizeMB . Via this field, users can easily determine

metadata:
  config:
    bucket: cbes-checkpoint-ProductCenter
    connectionBufferSizeMB: 5mb

dcp:
  connectionTimeout: 10s
  connectionBufferSizeMB: 20mb

etc.

Currently, I try to support connectionBufferSize in not order to break compatibility. I signed this field as deprecated on README.

Abdulsametileri commented 1 year ago

No required to keep open this PR, I have opened more expanded version of it: https://github.com/Trendyol/go-dcp/pull/71