search

Trendyol / go-dcp

The Go implementation of the Couchbase DCP with various features
MIT License
85 stars 15 forks source link

implement cb default port #96

Closed keremdndr closed 6 months ago

keremdndr commented 6 months ago

Resolves #95

When more than one couchbase data node IP is given, an error is received when connecting because the default port is not set.

The default port set as 8091.

erayarslan commented 6 months ago

@keremdndr thank you so much for contribution. can we add unit test for resolveHostsAsHTTP to make sure don not break it in the future?

keremdndr commented 6 months ago

I implemented unit tests. Also, I am the keremdundarty user, there was some confusion among the users in my local 😄 @erayarslan

erayarslan commented 6 months ago

@keremdndr you can fix latest commit user with force push. its important for your contribution history on github. if u force push latest commit with your githuh email, it will fixed.