search

Trendyol / gurubu

Simple, Fast, and Practical Task Estimation and Tech Grooming. Live demo below 👇
https://gurubu.vercel.app
BSD 3-Clause "New" or "Revised" License
59 stars 16 forks source link

Wihout entering nickname, create room button must be disabled #116

Open mevlutcantuna opened 7 months ago

mevlutcantuna commented 7 months ago

If a user doesn't enter a nickname and clicks the create room button, it waits forever and the user must refresh the page. Instead, the create room button can be disabled.

Ekran Resmi 2024-02-07 16 05 10

mevlutcantuna commented 7 months ago

Hi @armagandalkiran @mertcanaltin,

If there is a design for the disabled state of a button component, I would like to implement it and if there is not, I can give it opacity.It will be showed like below.

Ekran Resmi 2024-02-07 16 11 57

armagandalkiran commented 7 months ago

Thank you for your attention. @aahmetcakir can you take a look kardo ?

aahmetcakir commented 6 months ago

we can use https://www.figma.com/file/3Rvo2R5AWAse3O09KtuhZT/GurubuV2?type=design&node-id=741-6773&mode=design&t=8k47OFWrDFRpTIi3-0 this design karo

mevlutcantuna commented 6 months ago

@aahmetcakir @armagandalkiran this pr fixes this issue. https://github.com/Trendyol/gurubu/pull/145