search

Trendyol / kink

KinK is a helper CLI that facilitates to manage KinD clusters as Kubernetes pods. Designed to ease clusters up for fast testing with batteries included in mind.
Apache License 2.0
373 stars 28 forks source link

Add missing name input on the delete command #77

Closed gadiener closed 1 year ago

gadiener commented 2 years ago

Thanks for the effort spent on this project!

Currently, the delete command doesn't support deleting a single cluster without selecting it with the interactive shell. This pull request adds the --name option to allow this behavior.

There is also the new --silent flag to skip the last interactive confirmation to make running the CLI in the CI/CD easier.

I am looking forward to hearing your feedback and comments.

brenwell commented 2 years ago

Looks good!

gadiener commented 2 years ago

@developer-guy, sorry to ping you directly here. Perhaps you can help with a review?

developer-guy commented 2 years ago

Great, thanks for your interest 🤗I'll take a look at it ASAP

gadiener commented 2 years ago

I see the CI failed on the golangci stage. I tried running it locally, and it seems to pass without any issue. Do you have any tips on that?

gadiener commented 2 years ago

Morning @developer-guy, I'm looking forward to get your feedback here