I1389 run conf hash - Githubissues

TresAmigosSD / SMV

Spark Modularized View

Apache License 2.0

42 stars 22 forks source link

I1389 run conf hash #1395

Closed ninjapapa closed 5 years ago

ninjapapa commented 5 years ago

Fixed #1389

Instead of use SmvRunConfig mix-in to override requiresConfig, use a "private" function _all_run_conf_keys, since client code typically has MyModule(SmvModule, SmvRunConfig) form, which SmvModule overrides SmvRunConfig.

ninjapapa commented 5 years ago

close to fix test.

ninjapapa commented 5 years ago

I forced pushed the branch, so no way to reopen this. Will start a new PR and point back.