search

TresAmigosSD / SMV

Spark Modularized View
Apache License 2.0
42 stars 22 forks source link

Provider discovery will not pickup module mix-in with provider #1561

Closed ninjapapa closed 5 years ago

ninjapapa commented 5 years ago

Example:

class MyNewModule(SmvModule, SmvProvider):
    ....

In this case MyNewModule is abstract (just the same as SmvModule), so provider discovery will ignore it. It should not be.

The reason is that _matchingClassesInPyModule (used by provider discovery) filter out abstract classes. Need to add a flag to this method, and use the non-filter version for providers.