ContactShadows demo throws error

andretchen0 commented 12 months ago

Describe the bug

The guide page at:

https://cientos.tresjs.org/guide/staging/contact-shadows.html

throws an error:

Uncaught (in promise) TypeError: "position" is read-only

This appears related to ContactShadows helper prop:

When true, the error is thrown.
Whenfalse, the error is not thrown.

Reproduction

https://stackblitz.com/edit/tresjs-basic-pfyd2g?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

Open the StackBlitz or open the guide.
Check the browser console.

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1
    Memory: 102.31 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.5.1 - /opt/homebrew/bin/node
    npm: 9.8.0 - /opt/homebrew/bin/npm
    pnpm: 8.6.5 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 116.0.5845.187
    Safari: 16.2
  npmPackages:
    @tresjs/core: ^3.2.1 => 3.2.1 
    @tresjs/eslint-config-vue: ^0.1.1 => 0.1.1 
    vite: ^4.4.9 => 4.4.9

Used Package Manager

pnpm

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

andretchen0 commented 9 months ago

Additional ContactShadows problems, in ./playground/src/pages/staging/ContactShadowsDemo.vue

the shadows disappear when the "resolution" slider is changed in the UI
the shadow color doesn't change when state.color is changed in the UI

For clarity, the UI is currently being ported from TweakPane to TresLeches. But the problems occur regardless of the UI library used.

Here's the Leches version of the UI in question:

@alvarosabu – I noticed the above when porting the UI to Leches. Just in case you want to take a look.

alvarosabu commented 9 months ago

Hi @andretchen0 I think there are several issues with that component and reactivity, I will take it

JaimeTorrealba commented 2 weeks ago

Should we close this one? @alvarosabu @andretchen0

Tresjs / cientos