search

Tresjs / cientos

Collection of useful helpers and fully functional, ready-made abstractions for TresJS
https://cientos.tresjs.org/
MIT License
281 stars 40 forks source link

chore: fix linter errors #394

Closed andretchen0 closed 5 months ago

andretchen0 commented 5 months ago

Problem

Cientos' main is failing the CI linter step.

The <PositionalAudio /> component got committed to main. It has linter errors according to the recently updated eslint rules.

Since the linter errors have been merged into main, branches based on main also can't pass the local linter and fail the CI linter.

Solution

Fixed the linter errors in <PositionalAudio />.

Context

@damienmontastier , first: no worries. I imagine this is just a case of PR making it into main around the time the linter rules were updated.

Second: I've verified that the component works to the best of my knowledge, but please have a look. The linter was unable to automatically fix a number of reported errors, so I had to make a number of changes by hand.

Third: feel free to ignore here and open a fresh PR with your fixes.

I usually don't like to edit others' components, but since this is blocking all other PRs, I wanted to speed up an eventual fix.

stackblitz[bot] commented 5 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

damienmontastier commented 5 months ago

@andretchen0 Yes, the lint had changed and my code was no longer correct. Sorry about that! Everything seems OK with your changes. 👌