Tresjs / leches

🍰 Tasty GUI for Vue controls
https://tresleches.tresjs.org/
MIT License
28 stars 5 forks source link

style: Implement Dark Mode #95

Open Readpato opened 9 months ago

Readpato commented 9 months ago

Description

Summary

Changes

What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)

Does this PR introduce a breaking change? (check one)

Screenshots and videos

https://github.com/Tresjs/leches/assets/87768087/d9b68b2c-660a-4cea-a2cd-faa29c60581f

The PR fulfils these requirements:

If adding a new feature, the PR's description includes:

Dark mode is a good implementation to improve the UX for everyone that utilizes the package.

Other information:

Let me know any changes that need to be done if needed!

netlify[bot] commented 9 months ago

Deploy Preview for tresleches ready!

Name Link
Latest commit a6198c54e089f97189251711b419103efcfe4e5d
Latest deploy log https://app.netlify.com/sites/tresleches/deploys/65801f6fce7048000877fe7c
Deploy Preview https://deploy-preview-95--tresleches.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alvarosabu commented 8 months ago

Hey @Readpato thanks for taking the time to bring everything from the fork to the repo and for the granular and detailed git commit history, πŸ‘πŸ»

Small thing, (I missed it when asking the first time) when creating the branch add the number of the issue like feat/75-dark-mode

I'm gonna check the PR today, let you know soon

alvarosabu commented 8 months ago

Screenshot 2023-12-18 at 11 06 38

Folders look different now, they had a subtle gray background and no border before.

alvarosabu commented 8 months ago

@Readpato I just committed a small change regarding the styles of the icon for toggling the dark mode.

Before it had the same visual hierarchy as the cake icon (which symbolizes the mini branding of the component and will serve as an expand/collapse button in the near future) so since the functionality is also different I changed for a more subtle icon (also the right part is gonna serve as a toolbar of actions, where we will add a search icon soon)

Screenshot 2023-12-18 at 11 29 25 Screenshot 2023-12-18 at 11 29 38

Let me know what do you think

Readpato commented 8 months ago

Hey @alvarosabu! Thank you for your review. Means a lot <3 I'm totally on board with utilizing an icon instead of an emoji for toggling the dark mode. Also, I was wondering to properly commit to a project, sometimes I notice that different files are being modified automatically like stats.html, auto-imports.d.ts, etc. Should I commit those as well whenever I work on the project?