Tresjs / tres

Declarative ThreeJS using Vue Components
https://tresjs.org
MIT License
1.91k stars 85 forks source link

refactor: playground housekeeping #719

Closed andretchen0 closed 2 weeks ago

andretchen0 commented 4 weeks ago

As discussed on the Discord, this is a housekeeping PR, cleaning up playground.

Problem

/playground/src/components is a spot for shared playground components. There are a number of components in the folder and many are only used once.

Solution

Components only used once were reorganized into folders with their parent components

Problem

It's useful to put an issue reproduction in the playground for local testing and for sharing. But it wasn't clear where these reproductions should go or how to signal that a component was meant to be a reproduction.

Solution

Added an "Issues" category

Meta

Suggested by @garrlker


Meta

This PR builds on elements added to the playground in #717 . It should be approved/merged first.

netlify[bot] commented 4 weeks ago

Deploy Preview for tresjs-docs ready!

Name Link
Latest commit 5f8a524a8159863da6087adba9884470713eb50d
Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/666d5d2af85ce500084b7235
Deploy Preview https://deploy-preview-719--tresjs-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andretchen0 commented 4 weeks ago

I like the category issues, just wondering if it would get too populated eventually.

Too many items in the category? I could see that happening.

We could always create an "Issues archive" category that isn't listed on the playground landing page. But we can handle that if we get there.

alvarosabu commented 4 weeks ago

We could always create an "Issues archive" category that isn't listed on the playground landing page. But we can handle that if we get there.

Sounds good to me