Tresjs / tres

Declarative ThreeJS using Vue Components
https://tresjs.org
MIT License
1.91k stars 85 forks source link

Deltatime Documentation Inaccuracy #750

Closed nart4hire closed 4 hours ago

nart4hire commented 4 days ago

Describe the bug

In the docs, delta is described as milliseconds from last frame, which is inaccurate since under the hood it uses Clock.deltaTime() which is in seconds.

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-tuauqe?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

Just use the useLoop function as described in the documentation

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700K
    Memory: 21.41 GB / 31.77 GB
  Binaries:
    Node: 21.7.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.2 - C:\ProgramData\chocolatey\bin\pnpm.EXE
  Browsers:
    Edge: Chromium (126.0.2592.81)
    Internet Explorer: 11.0.22621.3527

Used Package Manager

pnpm

Code of Conduct