Rigged models are squished and broken

alvarosabu commented 4 months ago

Describe the bug

Adding a rigged model with useGLTF looks squished and broken

Screenshot 2024-06-29 at 11 53 14

Reproduction

https://stackblitz.com/~/edit/tresjs-squished-models?file=src/App.vue

Steps to reproduce

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @tresjs/cientos: 3.9.0 => 3.9.0 
    @tresjs/core: 4.0.2 => 4.0.0 
    vite: ^5.3.2 => 5.3.2

Used Package Manager

npm

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

alvarosabu commented 4 months ago

cc @andretchen0 so you have it on your radar, seems like a regression bug from the core v4. It might be related to changes on primitives. Could you please check if in your PR with the new approach on primitives this is solved? Thanks

alvarosabu commented 4 months ago

Seems to be a regression issue related to primitives changes from core v3.9.0 -> v4.0.0. Will move this to the core package

andretchen0 commented 4 months ago

In case it's useful in the future, here's the change that caused the regression:

https://github.com/Tresjs/tres/commit/79d8a762da6b6e23771a20314f7902eff4635acf#diff-505c62067e9b13b6e4515b24b16c4ac03af37d111601d5a81acf355af29c8fc5L52

Changes to the primitive implementation are currently underway. The model displays and animates as expected with the new WIP implementation:

Tresjs / tres