Component: The setting parameter disableRender of TresCanvas is ineffective when renderMode is set to always.

Tresjs / tres

Declarative ThreeJS using Vue Components

https://tresjs.org

MIT License

2.16k stars 102 forks source link

Component: The setting parameter disableRender of TresCanvas is ineffective when renderMode is set to always. #766

Closed hawk86104 closed 4 days ago

hawk86104 commented 2 months ago

Describe the bug

As mentioned in the title, in version v4.1.0

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-7tdaba?file=src%2FApp.vue

Steps to reproduce

No response

System Info

No response

Used Package Manager

npm

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

hawk86104 commented 2 months ago

v4.10 lib file：src/utils/index.ts setPrimitiveObject

// NOTE: copy added/attached Vue children // We need to insert objects into newObject later. // In the meantime, remove(primitive) will alter // the array, so make a copy.

I believe there is an issue with this. In the following code, meshOB cannot be operated on.

<primitive :object="gridHelp" />

gridHelp.parent 
gridHelp.visible = false

alvarosabu commented 2 months ago

Actually that prop disableRender should be deprecated

Neosoulink commented 1 month ago

@alvarosabu I can work on this if no one already working on this one

Tinoooo commented 5 days ago

Deprecating the prop is not possible anymore as it already has no effect. I removed it in #838.