search

Trevoke / sqlup-mode.el

An emacs minor mode to upcase SQL keyword and functions
GNU General Public License v3.0
88 stars 15 forks source link

Use sql-product from sql-mode if available #23

Closed ian-kelling closed 10 years ago

Trevoke commented 10 years ago

If I understand, this pull request is assuming that you could have an sql-product bound without a syntax table already loaded by sql-mode, is that correct?

My code's understanding of the world is that either you have a syntax table or you should default to the ANSI syntax table.

What problem is your pull request solving / what use case is it fulfilling?

ian-kelling commented 10 years ago

If I understand, this pull request is assuming that you could have an sql-product bound without a syntax table already loaded by sql-mode, is that correct?

Yes.

If you custom set, or setq sql-product, it will be available when you are not in sql-mode, and sql-mode-font-lock-keywords is not available. Your comment made me update the request slightly to check that sql-mode-font-lock-keywords is not nil. sqlup-mode does not actually work for me outside of sql-mode, probably some other small bug, but that was the use case in mind.

Trevoke commented 10 years ago

Weird.. My primary use case for sqlup is outside sql-mode right now. Well - thanks for this bugfix! :)