search

Trevoke / sqlup-mode.el

An emacs minor mode to upcase SQL keyword and functions
GNU General Public License v3.0
88 stars 15 forks source link

Add testing #44

Closed Trevoke closed 8 years ago

Trevoke commented 8 years ago

This PR adds testing in two ways: unit tests with ert and end-to-end tests with ecukes.

Ping @yogsothoth - what do you think of this? Given the tools provided by ecukes/espuds, including switching buffers, I'm tempted to keep ecukes, to allow me to test for how sqlup works when used in multiple buffers.

Before merging this, I will need to go to melpa and double-check how I am telling melpa to pull from this repo; I don't think users need to download the tests to use the package.

yogsothoth commented 8 years ago

This looks very good to me and like you say, testing with multiple buffers is the thing to do, definitely. I'll try to ramp up on this and add some tests this evening (10 hours from now, GMT+1).

Trevoke commented 8 years ago

Awesome, thanks.

This branch won't be merged in by the time you get to it, unfortunately, but this is just git, so it shouldn't really be a problem.