search

Trevoke / sqlup-mode.el

An emacs minor mode to upcase SQL keyword and functions
GNU General Public License v3.0
88 stars 15 forks source link

Fix capitalizing symbols which partially match a keyword #51

Closed davidshepherd7 closed 8 years ago

davidshepherd7 commented 8 years ago

Closes #50

Unfortunately I couldn't get a failing test for this, not sure why.

davidshepherd7 commented 8 years ago

Urgh, this seems to have broken some other tests though...

They seem to be yet another case of the tests failing but it actually working :(

Trevoke commented 8 years ago

After merging this locally, there definitely is a new failing test. I don't know why this occurs, but now we can probably bring in @rejeep and ask him since there's this thing we can't get to fail, and https://github.com/Trevoke/sqlup-mode.el/issues/49 where the test fails but the code works in emacs.

davidshepherd7 commented 8 years ago

So, I just found that we weren't actually turning on sql mode in the tests! With that fixed things seem to make sense again :)

davidshepherd7 commented 8 years ago

Closing to recreate a cleaned up version on a non-master branch.

rejeep commented 8 years ago

Did you sort everything out?

Trevoke commented 8 years ago

@rejeep Hi, it looks like we did, yes, thanks. The only question I had for you was, in ecukes, what is the default major mode for the created buffers for the test?

rejeep commented 8 years ago

@Trevoke Should be fundamental-mode unless you add some custom code yourself. Ecukes does not do anything magic, it only starts Emacs.

Trevoke commented 8 years ago

OK, thank you!