Cannot read property "left" of undefined

TrevorBarns / luxart-vehicle-control

A siren / (non-els) emergency lights controller for FiveM.

https://www.luxartengineering.com/

GNU General Public License v3.0

135 stars 56 forks source link

Cannot read property "left" of undefined #33

Closed Lutton-alliance closed 3 years ago

Lutton-alliance commented 3 years ago

Uncaught typeError: Cannot read property "left" of undefined

Error apparently occurs in UI/html/lvc.js line 96

There also is another issue that nobody else can hear your sirens (using wm-serversirens) after a while (unknown if connected to this issue, but probably not)

TrevorBarns commented 3 years ago

Yes, this is an error LVC has received for a while now. It does not have an effect on functionality or stability. Think of it more as a warning. Has to do with saving hud position after reset.

In regards to sirens shutting off using wm-ss I'll have to look into that.. How long after? Does it happen with regular sirens?

Lutton-alliance commented 3 years ago

The sirens appeared to have turned off when in a group of 5-6 were on; only some though. We could only hear default gta 5 police cars (not even addon cars which had the default siren attached)

TrevorBarns commented 3 years ago

The sirens appeared to have turned off when in a group of 5-6 were on; only some though. We could only hear default gta 5 police cars (not even addon cars which had the default siren attached)

Likely an error occurred crashing the client side for some people. Review their FiveM logs under FiveM AppData/logs see if you find any errors with "lvc" in it.

Which version is this?

Lutton-alliance commented 3 years ago

It was the current release version we were using; I'm not sure as there wasn't anything in particular that stood out in their logs with "lvc". I can certainly see if it happens again today and get the logs as soon as I can

TrevorBarns commented 3 years ago

Could be an LVC bug or a configuration error (WM-ServerSirens Integration) that is resulting in some unintended results.

Lutton-alliance commented 3 years ago

Yeah could be, I will let you know if it happens again I guess

Lutton-alliance commented 3 years ago

CitizenFX_log_2021-08-12T214145.log

Thats the log file that I got given.

TrevorBarns commented 3 years ago

So I do not see any errors in the log or in your SIRENS.lua. So LVC will continue working for default sirens from resident.rpf, but WM-ServerSiren tones break? Disregard any sounds coming from AI cops because LVC does not control them so even if LVC breaks, AI cops will continue to work.

How often and how quickly does it occur?
Can you get a video of it happening?
What happens when officers try and toggle siren after it has happened?
Continue to try and find any errors in logs from clients or server when it occurs.

Lutton-alliance commented 3 years ago

So whenever it "breaks", there are no siren sounds emitted from a server sided perspective. Only the client can hear their own siren and nobody else. As of now, it does not work at all, irregardless of server restarts or anything. Players may toggle it on and off but only they will hear the siren.

TrevorBarns commented 3 years ago

Are you on OneSync?

Lutton-alliance commented 3 years ago

We are not using OneSync no.

TrevorBarns commented 3 years ago

This is embarrassing, a mistake was made in prep for 3.2.4 release which resulted in incorrect event names. Please download the new revision 1 release here: https://github.com/TrevorBarns/luxart-vehicle-control/releases/tag/3.2.4

Sorry for any inconvenience.

Lutton-alliance commented 3 years ago

All good no worries; Im sure I have made worse mistakes